Fix 2.6 NoSuchElementException in AA code. #11734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This would happen if a unit has special chars in its aaType, causing it to be evaluated as a regex instead of an exact match.
This specifically broke the code pattern (e.g. in FiringGroupSplitterAa):
final List<String> typeAas = UnitAttachment.getAllOfTypeAas(aaUnits);
for (final String typeAa : typeAas) {
final Collection<Unit> firingUnits =
CollectionUtils.getMatches(aaUnits, Matches.unitIsAaOfTypeAa(typeAa));
Causing an empty `firingUnits` due to typeAa being evaluated as a regex.
I checked all the callsites and verified none of them actually require the regex behavior.
Fixes: triplea-game#11458
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary & Additional Notes
Fix 2.6 NoSuchElementException in AA code.
This would happen if a unit has special chars in its aaType, causing it to be evaluated as a regex instead of an exact match. This specifically broke the code pattern (e.g. in FiringGroupSplitterAa):
Causing an empty
firingUnitsdue to typeAa being evaluated as a regex. I checked all the callsites and verified none of them actually require the regex behavior.Fixes: #11458
Release Note